[diffs] CodeView Layout & Options Optimizations#718
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d60fd50625
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
amadeus
force-pushed
the
amadeus/cache-estimated-heights
branch
from
d60fd50 to
088df82
Compare
amadeus
force-pushed
the
amadeus/cache-estimated-heights
branch
from
088df82 to
45a508d
Compare
amadeus
force-pushed
the
amadeus/cache-estimated-heights
branch
from
45a508d to
e730f08
Compare
Create small reusable utilities for the estimate helper and existing virtual layout code. - Extract or share the `getExpandedRegion` logic currently inside `iterateOverDiff` so expansion math cannot drift. - Add a separator estimate helper that mirrors renderer/CSS behavior. - Keep these helpers pure and independent of `VirtualizedFileDiff` instance state. Separator helper rules: - `simple`: render only when `hunkIndex > 0`; height is `metrics.hunkSeparatorHeight ?? 4`. - `metadata`: render only when `hunkSpecs != null`; height is `metrics.hunkSeparatorHeight ?? 32`. - `line-info-basic`: height is `metrics.hunkSeparatorHeight ?? 32`. - `line-info`: height is `metrics.hunkSeparatorHeight ?? 32`, plus top/bottom spacing based on first/last position. - `line-info`: omit top gap for `isFirstHunk`. - `line-info`: omit bottom gap for `isLastHunk`. - `custom`: estimate like `line-info` unless we decide to force custom separators to be measurement-only later.
amadeus
force-pushed
the
amadeus/cache-estimated-heights
branch
from
e730f08 to
863c86d
Compare
amadeus
changed the title
Member
Author
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a60b37fbb3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
amadeus
force-pushed
the
amadeus/cache-estimated-heights
branch
from
d601a30 to
b7fa26b
Compare
Member
Author
|
@codex review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Went a bit deep on optimizing option and layout changes, especially in more pathological that involved moving from split to unified. These are both performance and memory optimizations.
Results
I would share a video but it's too big for github. Some approximate numbers, the linux diff used to take around 200-300ms when toggling between split and unified. Now it should be sub 40ms. Stilll not as fast as I would like, but usable. Also memory usage i think dropped by 50-100mb in the extreme linux variant with the new shared options logic.